TPT-4480: Added support for Configurable VPC IPv4 Prefixes#707
Draft
ezilber-akamai wants to merge 4 commits into
Draft
Conversation
ezilber-akamai
requested review from
jriddle-linode and
mawilk90
and removed request for
a team
ezilber-akamai
changed the title
mawilk90
reviewed
Jun 12, 2026
| region=region, | ||
| description="integration test vpc with ipv4", | ||
| ipv4=[{"range": "10.0.0.0/8"}], | ||
| ) |
Contributor
There was a problem hiding this comment.
Does it make sense to extract a fixture responsible for creating and deleting VPC with ipv4 ranges instead of doing so directly in the test? Thanks to that it would be cleaner (no try-finally needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for the new GET /v4/vpcs/default-ranges endpoint and updated the following endpoints to support IPv4:
NOTE: API Documentation link needs to be added
✔️ How to Test
make test-unitmake test-int TEST_CASE=test_get_vpc_default_rangesmake test-int TEST_CASE=test_vpc_with_ipv4